Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Arithmetic circuit library subtractors #6490

Closed
wants to merge 4 commits into from

Conversation

ManjulaGandhi
Copy link
Contributor

Summary

Implementing Twos Complement Subtractor

Details and comments

Tests are still missing

@HuangJunye HuangJunye added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 21, 2022
@jakelishman
Copy link
Member

@Cryoris: I don't know the purpose of the classical arithmetic parts of the circuit library, but I think you might know the history. This PR is old and never saw review, but is from around the time of some other modifications to the arithmetic library (esp #6470) - please could you judge if it's something useful that we should include, or close the PR if not?

@Cryoris
Copy link
Contributor

Cryoris commented Mar 10, 2023

Yeah this would be useful to have to complete the operations in the arithmetic circuit library 🙂

@ManjulaGandhi would you still be interested in pursuing this? Otherwise we can also close it and see if we can pick it up in the future 🙂

@ManjulaGandhi
Copy link
Contributor Author

@Cryoris yes interested to complete this task.

@jakelishman
Copy link
Member

I'm going to close this PR now due to lack of activity, but if @Cryoris and @ManjulaGandhi are committed to getting this actually merged, please feel free to re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants