-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update top level provider documentation for BackendV2 #7323
Conversation
Pull Request Test Coverage Report for Build 1527872187
💛 - Coveralls |
38c9418
to
4e4b4d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick read through. I don't know enough about what's happened in the main BackendV2
PR to properly review the content, but the bits I do know looked correct to me.
12673dd
to
b445912
Compare
As a follow-on to Qiskit#5885 this commit updates the top level qiskit.providers module documentation for BackendV2. This primarily consists of two things, updating the writing a provider section to use BackendV2 instead of BackendV1 and adding a migration section on user facing changes between BackendV1 and BackendV2.
b445912
to
4be51fb
Compare
Ok, now that #5885 has merged I've rebased this on the merged version and it's no longer blocked |
The following sentence sounds repetitive:
I suggest:
|
:meth:`~~qiskit.providers.BackendV2.run` method. | ||
|
||
* Add any custom gates for the backend's basis to the session | ||
:class:`~qiskit.circuit.EquivalenceLibrary` instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this spacing intentional?
:meth:`~~qiskit.providers.BackendV2.run` method. | |
* Add any custom gates for the backend's basis to the session | |
:class:`~qiskit.circuit.EquivalenceLibrary` instance. | |
:meth:`~~qiskit.providers.BackendV2.run` method. | |
* Add any custom gates for the backend's basis to the session | |
:class:`~qiskit.circuit.EquivalenceLibrary` instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, the custom gates thing is a sub-bullet of building a backend (as it's an optionally a part of building a backend class) see where @jakelishman asked the same thing: #7323 (comment)
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Done in: 254270d I also updated the link to the repo's current home |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
As a follow-on to #5885 this commit updates the top level
qiskit.providers module documentation for
BackendV2
. This primarilyconsists of two things, updating the writing a provider section to use
BackendV2
instead ofBackendV1
and adding a migration section on userfacing changes between
BackendV1
andBackendV2
.Details and comments