-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reverse_bits to support registerless bits #7423
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f39905d
Improve reverse_bits to support registerless bits
yjt98765 626ed88
Change the algorithm of reverse_bits
yjt98765 61d2d29
Merge branch 'main' into hotfix-7415
yjt98765 23a06a8
Merge branch 'main' into hotfix-7415
yjt98765 d0d8cc8
Reimplement reverse_bits with reversed bits
yjt98765 bc20ea4
Merge branch 'main' into hotfix-7415
yjt98765 62420f9
Merge branch 'main' into hotfix-7415
yjt98765 46e239c
Merge branch 'main' into hotfix-7415
yjt98765 0686d76
Merge branch 'main' into hotfix-7415
yjt98765 c7060d1
Merge remote-tracking branch 'ibm/main' into hotfix-7415
jakelishman 8ba1983
Simplify bit lookups
jakelishman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
releasenotes/notes/fix-reverse_bits-with-registerless-bits-6d17597b99640fb0.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
fixes: | ||
- | | ||
Fixed :meth:`.QuantumCircuit.reverse_bits` with circuits containing registerless | ||
:class:`.Qubit` and :class:`.Clbit`. For example, the following will now work:: | ||
|
||
from qiskit.circuit import QuantumCircuit, Qubit, Clbit | ||
|
||
qc = QuantumCircuit([Qubit(), Clbit()]) | ||
qc.h(0).c_if(qc.clbits[0], 0) | ||
qc.reverse_bits() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good test. Please could you also add some tests where there's a mix of registers and registerless bits, and some where there are some registers that overlap with each other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added three additional test cases. They succeeded with the new logic. The downside may be that the way of constructing the
expect
circuit is not very straightforward, especially in the cases of overlapping bits.