Add interfaces for a general Quantum Time Evolution Framework #7858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interfaces. (Qiskit#7669)" (Qiskit#7845)" This reverts commit 1b6c1b3. Co-authored-by: dlasecki <dal@zurich.ibm.com>
Cryoris
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
Pull Request Test Coverage Report for Build 2109613951
💛 - Coveralls |
mtreinish
reviewed
Apr 1, 2022
There was a problem hiding this comment.
Before we approve and merge this I had a question inline. I know this is a straight revert of a revert and should be just mechanical, but I missed the initial PR, and part of what caught my eye when going over the release in #7828 was some of the class hierarchy which was confusing to me.
5 tasks
dlasecki
previously approved these changes
Apr 5, 2022
woodsp-ibm
reviewed
Apr 5, 2022
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
woodsp-ibm
previously approved these changes
Apr 5, 2022
woodsp-ibm
approved these changes
Apr 6, 2022
mtreinish
approved these changes
Apr 7, 2022
mtreinish
changed the title
mtreinish
added
Changelog: New Feature
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
…#7858) * Revert "Revert "Implemented general Quantum Time Evolution Framework interfaces. (Qiskit#7669)" (Qiskit#7845)" This reverts commit 12ab98d. Co-authored-by: dlasecki <dal@zurich.ibm.com> * remove Evolver base class * Don't import list or dict from MES Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * fix import order Co-authored-by: dlasecki <dal@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
…/qiskit#7858) * Revert "Revert "Implemented general Quantum Time Evolution Framework interfaces. (Qiskit/qiskit#7669)" (Qiskit/qiskit#7845)" This reverts commit 2a7ffe9. Co-authored-by: dlasecki <dal@zurich.ibm.com> * remove Evolver base class * Don't import list or dict from MES Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * fix import order Co-authored-by: dlasecki <dal@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit 1b6c1b3.
Details and comments
We removed the time evolution interface from the 0.20 release since there were no algorithms that implemented them and didn't want to expose users to these classes without being able to use them. Now that the release is out, we can add them back in.