Follow-up on routing commuting 2q gates #7979
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2302788972
💛 - Coveralls |
qiskit/transpiler/passes/routing/commuting_2q_gate_routing/commuting_2q_block.py
Outdated
Show resolved
Hide resolved
…j/qiskit-terra into routing_commuting_gates_follow_up
…j/qiskit-terra into routing_commuting_gates_follow_up
eggerdj
changed the title
| from .swap_strategies.commuting_2q_gate_router import Commuting2qGateRouter | ||
| from .swap_strategies.swap_strategy import SwapStrategy | ||
| from .commuting_2q_gate_routing.commuting_2q_gate_router import Commuting2qGateRouter | ||
| from .commuting_2q_gate_routing.swap_strategy import SwapStrategy |
There was a problem hiding this comment.
can you remove SwapStrategy from init of qiskit.transpiler.passes? It's not a pass (contrary to all the other things in that namespace, which so far has been a nice place to show all passes in qiskit). I think people can import it from either qiskit.transpiler.passes.routing.swap_strategy or at least qiskit.transpiler.passes.routing
There was a problem hiding this comment.
Sure, this should cover it: c4d2f20
* * Renamed directory. * * Typo. * * Commuting2qBlocks name * * logical -> virtual. * * from_line in the example. * * Reno name fix. * * Reno rewording. * * removed unnecessary line in example. * * Black. * * Started designing test on non-line graph. * * Added test on a T device. * * Renamed Communting2qBlocks to Commuting2qBlock * * Made test robust to arbitraryness of commuting gate order. * Added test. * * Added test and black. * * Fix missing gate test exception refactor. * * Bug fix with test. * * Removed SwapStrategy from the passes init. * * black
Summary
This is a PR to address the remaining comments in #7813 .
Details and comments
See the response to the comments in #7813.