Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard time limit from vf2 passes in preset passmanagers #8021

Merged
merged 3 commits into from
May 4, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
upgrade:
- |
The preset pass managers generated by :func:`~.level_1_pass_manager`,
:func:`~.level_2_pass_manager`, and :func:`~.level_3_pass_manager` and used
by the :func:`~.transpile` function's ``optimization_level`` argument at
1, 2, and 3 respectively no longer is setting a hard time limit on the
jakelishman marked this conversation as resolved.
Show resolved Hide resolved
:class:`~.VF2Layout` transpiler pass. This means that the pass will no
longer stop trying to find a better alternative perfect layout up until a
fixed time limit (100ms for level 1, 10 sec for level 2, and 60 sec for
level 3) as doing this limited the reproducibility of compilation when a
perfect layout was available. This means that the output when using the pass
might be different than before, although in all cases it would only change
if a lower noise set of qubits can be found over the previous output. If
you wish to retain the previous behavior you can create a custom
:class:`~.PassManager` that sets the ``time_limit`` argument on the
constructor for the :class:`~VF2Layout` pass.
fixes:
- |
Fixed an issue with reproducibility of the :func:`~.transpile` function
when running with ``optimization_level`` 1, 2, and 3. Previously, under
some conditions when there were multiple perfect layouts (a layout that
doesn't require any SWAP gates) available the selected layout and output
circuit could vary regardless of whether the ``seed_transpiler`` argument
was set.