Fix RZX builder rescaled amplitude #8031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkanazawa1989
requested review from
a team,
eggerdj and
DanPuzzuoli
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
nkanazawa1989
added
the
Changelog: Bugfix
mtreinish
added
the
stable backport potential
Pull Request Test Coverage Report for Build 2309370174
💛 - Coveralls |
jakelishman
reviewed
May 11, 2022
releasenotes/notes/fix-rzx-builder-pulse-amp-ba5c876ddea17c41.yaml
Outdated
Show resolved
Hide resolved
jakelishman
approved these changes
May 11, 2022
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
mergify bot
pushed a commit
that referenced
this pull request
May 11, 2022
* Fix RZX builder rescale amplitude bug * Update releasenotes/notes/fix-rzx-builder-pulse-amp-ba5c876ddea17c41.yaml Co-authored-by: Jake Lishman <jake@binhbar.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 829f232)
mergify bot
added a commit
that referenced
this pull request
May 11, 2022
* Fix RZX builder rescale amplitude bug * Update releasenotes/notes/fix-rzx-builder-pulse-amp-ba5c876ddea17c41.yaml Co-authored-by: Jake Lishman <jake@binhbar.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 829f232) Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
ajavadia
pushed a commit
to ajavadia/qiskit
that referenced
this pull request
May 31, 2022
* Fix RZX builder rescale amplitude bug * Update releasenotes/notes/fix-rzx-builder-pulse-amp-ba5c876ddea17c41.yaml Co-authored-by: Jake Lishman <jake@binhbar.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug that RZX builder passes return rescaled pulse amplitude in the parameter expression type that results in this pulse visualization. @nbronn
Details and comments
thetais a value that is provided by circuit node, which is not typecasted to float after the value assignment. Thus computed CR amp becomes parameter expression without explicit typecast.