Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BackendV2 support for PassManagerConfig.from_backend() #8109

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

mtreinish
Copy link
Member

Summary

This commit fixes the PassManagerConfig.from_backend() constructor
method when running with a BackendV2 object. Previously this was not
correctly handled and it always assumed the input backend was a
BackendV1 object. This would cause an error if you ran the constructor
with a BackendV2.

Details and comments

This commit fixes the PassManagerConfig.from_backend() constructor
method when running with a BackendV2 object. Previously this was not
correctly handled and it always assumed the input backend was a
BackendV1 object. This would cause an error if you ran the constructor
with a BackendV2.
@mtreinish mtreinish added the Changelog: Bugfix Include in the "Fixed" section of the changelog label May 26, 2022
@mtreinish mtreinish added this to the 0.21 milestone May 26, 2022
@mtreinish mtreinish requested a review from a team as a code owner May 26, 2022 14:39
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented May 26, 2022

Pull Request Test Coverage Report for Build 2538212086

  • 19 of 20 (95.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 84.283%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/transpiler/passmanager_config.py 19 20 95.0%
Totals Coverage Status
Change from base Build 2538209771: 0.004%
Covered Lines: 54891
Relevant Lines: 65127

💛 - Coveralls

Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 42c72be into Qiskit:main Jun 21, 2022
@mtreinish mtreinish deleted the fix-pm_config-from-backend-v2 branch June 21, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants