Fix handling of numpy arrays for indices in marginal_distribution #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue with the marginal_distribution() function where it would previously error if a numpy arrray of ints was passed in for the indices parameter. This was caused by the input validation looking for empty input by checking `not indices` which isn't valid for numpy arrays. This commit fixes this by adjusting the check for empty lists to work with any sequence input. Fixes Qiskit#8283
mtreinish
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2598717170
💛 - Coveralls |
garrison
reviewed
Jul 25, 2022
releasenotes/notes/fix-numpy-indices-marginal-dist-45889e49ba337d84.yaml
Outdated
Show resolved
Hide resolved
…37d84.yaml Co-authored-by: Jim Garrison <jim@garrison.cc>
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
) * Fix handling of numpy arrays for indices in marginal_distribution This commit fixes an issue with the marginal_distribution() function where it would previously error if a numpy arrray of ints was passed in for the indices parameter. This was caused by the input validation looking for empty input by checking `not indices` which isn't valid for numpy arrays. This commit fixes this by adjusting the check for empty lists to work with any sequence input. Fixes #8283 * Update releasenotes/notes/fix-numpy-indices-marginal-dist-45889e49ba337d84.yaml Co-authored-by: Jim Garrison <jim@garrison.cc> Co-authored-by: Jim Garrison <jim@garrison.cc> (cherry picked from commit f868129)
mergify bot
added a commit
that referenced
this pull request
Jul 25, 2022
) (#8396) * Fix handling of numpy arrays for indices in marginal_distribution This commit fixes an issue with the marginal_distribution() function where it would previously error if a numpy arrray of ints was passed in for the indices parameter. This was caused by the input validation looking for empty input by checking `not indices` which isn't valid for numpy arrays. This commit fixes this by adjusting the check for empty lists to work with any sequence input. Fixes #8283 * Update releasenotes/notes/fix-numpy-indices-marginal-dist-45889e49ba337d84.yaml Co-authored-by: Jim Garrison <jim@garrison.cc> Co-authored-by: Jim Garrison <jim@garrison.cc> (cherry picked from commit f868129) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes an issue with the marginal_distribution() function
where it would previously error if a numpy arrray of ints was passed in
for the indices parameter. This was caused by the input validation
looking for empty input by checking
not indiceswhich isn't valid fornumpy arrays. This commit fixes this by adjusting the check for
empty lists to work with any sequence input.
Details and comments
Fixes #8283