Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified reps for ZZFeatureMap object created, to fit printed circuit #8333

Merged
merged 2 commits into from
Jul 13, 2022
Merged

modified reps for ZZFeatureMap object created, to fit printed circuit #8333

merged 2 commits into from
Jul 13, 2022

Conversation

googlercolin
Copy link
Contributor

Summary

Fixed example code for ZZFeatureMap object to match actual circuit printed

Details and comments

In Example 1, prep = ZZFeatureMap(2, reps=2) was used to print out a state preparation circuit with only 1 rep.

image

Modified the reps to prep = ZZFeatureMap(2, reps=1) to match what was printed in Example 1.

@googlercolin googlercolin requested a review from a team as a code owner July 13, 2022 07:15
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Cryoris
Copy link
Contributor

Cryoris commented Jul 13, 2022

Thanks for the contribution @googlercolin! I've noticed that the output of circuit.parameters is outdated, would you mind updating that too? 🙂

@googlercolin
Copy link
Contributor Author

googlercolin commented Jul 13, 2022 •
edited
Loading

Sure, let me work on that too @Cryoris :)

Just to clarify, it is classifier.parameters you are referring to yeah?

Cryoris
Cryoris approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc fixes!

@Cryoris Cryoris added automerge Changelog: None Do not include in changelog labels Jul 13, 2022
@mergify mergify bot merged commit 400fadf into Qiskit:main Jul 13, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2662576282

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 84.005%
Totals Coverage Status
Change from base Build 2658194086: 0.005%
Covered Lines: 55876
Relevant Lines: 66515
💛 - Coveralls

@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jul 25, 2022
mergify bot pushed a commit that referenced this pull request Jul 25, 2022
@googlercolin @mergify
modified reps for ZZFeatureMap object created, to fit printed circuit (…
6610115 
…#8333)

* modified reps for ZZFeatureMap object created, to fit printed circuit

* updated the output of classifier.parameters for Example 2

(cherry picked from commit 400fadf)
@mergify mergify bot mentioned this pull request Jul 25, 2022
Merged
mergify bot added a commit that referenced this pull request Jul 25, 2022
@mergify @googlercolin @mtreinish
modified reps for ZZFeatureMap object created, to fit printed circuit (…
bb9fd47 
…#8333) (#8395)

* modified reps for ZZFeatureMap object created, to fit printed circuit

* updated the output of classifier.parameters for Example 2

(cherry picked from commit 400fadf)

Co-authored-by: Colin Hong <Colin.hong@icloud.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@googlercolin @qiskit-bot @CLAassistant @Cryoris @coveralls @mtreinish