-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optimization for TwoLocal synthesis when entanglement='full' #8335
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this: |
Pull Request Test Coverage Report for Build 2782954860
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me, I think it would be nice to explain this optimization somewhere -- either in the NLocal docstring or in an extended comment inside the code.
I agree that we should add a docstring explaining this optimization, and will do it after finalizing the API. |
85b5839
to
ea6a404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is almost good to go! Two more things: Could you add a releasenote, and could you check the reverse_linear
entanglement works if it is used in the ZZFeatureMap
?
@Cryoris - thanks for the quick and helpful review. I think this PR is ready to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for this feature!
Summary
close #8294
Update the NLocal class.
Details and comments
When choosing a
TwoLocal
orRealAmplitude
orEfficientSU2
gate withentanglement=full
on n-qubits (for VQE ansatz),for a circuit with a
CX
sub-circuit, improve the number ofCX
gates fromn*(n-1)/2
CX
gates to onlyn-1
CX
gates with a linear connectivity