Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing aer_simulator_statevector checking method #8411

Merged
merged 5 commits into from
Aug 8, 2022
Merged

Changing aer_simulator_statevector checking method #8411

merged 5 commits into from
Aug 8, 2022

Conversation

doichanj
Copy link
Contributor

Summary

Changed comparison of backend name by using == to in if the backend is aer_simulator_statevector or not.

Details and comments

Because GPU simulator's backend name is aer_simulator_statevector_gpu using == returns False.
And some of the functionality of statevector simulator was not called correctly for GPU backend.

So by checking
if "aer_simulator_statevector" in backend.name():
returns True both for CPU and GPU simulator.

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Jul 28, 2022

Pull Request Test Coverage Report for Build 2800626840

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 84.037%

Totals Coverage Status
Change from base Build 2800102724: 0.003%
Covered Lines: 56089
Relevant Lines: 66743

💛 - Coveralls

@woodsp-ibm
Copy link
Member

Thanks for the fix. It looks good to but I think it needs a release note that describes the fix. See adding-a-new-release-note section of the contributing guide here if you need info on how to do that.

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the release note. Looks good to me now.

@Cryoris Cryoris added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog automerge labels Aug 8, 2022
@mergify mergify bot merged commit 6a5adf2 into Qiskit:main Aug 8, 2022
mergify bot pushed a commit that referenced this pull request Aug 8, 2022
* checking backend name by checking string is included

* added release note

(cherry picked from commit 6a5adf2)
mergify bot added a commit that referenced this pull request Aug 9, 2022
* checking backend name by checking string is included

* added release note

(cherry picked from commit 6a5adf2)

Co-authored-by: Jun Doi <doichan@jp.ibm.com>
ElePT pushed a commit to ElePT/qiskit-algorithms that referenced this pull request Jul 27, 2023
* checking backend name by checking string is included

* added release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants