-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing aer_simulator_statevector checking method #8411
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2800626840
💛 - Coveralls |
Thanks for the fix. It looks good to but I think it needs a release note that describes the fix. See adding-a-new-release-note section of the contributing guide here if you need info on how to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the release note. Looks good to me now.
* checking backend name by checking string is included * added release note (cherry picked from commit 6a5adf2)
* checking backend name by checking string is included * added release note
Summary
Changed comparison of backend name by using
==
toin
if the backend is aer_simulator_statevector or not.Details and comments
Because GPU simulator's backend name is
aer_simulator_statevector_gpu
using==
returnsFalse
.And some of the functionality of statevector simulator was not called correctly for GPU backend.
So by checking
if "aer_simulator_statevector" in backend.name():
returns True both for CPU and GPU simulator.