Remove tweedledum from macOS arm64 immediately #8849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskitgh-8818 we prevented macOS arm64 from attempting to use tweedledum 1.1.1 as no arm64 wheels are supplied for that version. In fact, the "arm64" and "universal2" wheels supplied for 1.1.0 are actually mislabelled x86_64 wheels as well, and so there is no working binary version of tweedledum for arm64, and the sdist build process works only rarely for most people. Since the work of Qiskitgh-8738 makes `tweedledum` _effectively_ optional for `import qiskit` with immediate effect, and the only way to have a working installation on M1 mac is essentially to have already manually built `tweedledum` from source, the effects of immediately removing the requirement from arm64 macs only should be very slight at worst, and a good quality of life improvement for normal M1 users.
jakelishman
added
the
Changelog: API Change
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3205145905
💛 - Coveralls |
mtreinish
approved these changes
Oct 7, 2022
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Oct 11, 2022
This commit fixes an oversight in Qiskit#8849 and Qiskit#8818 which made tweedledum optional for arm64 macOS systems which was the unittest suite still unconditionally depends on tweedledum being installed to run the classical function compiler tests. This commit fixes this by making the tests skip if tweedledum isn't installed so that M1 mac users are able to run the full test suite again.
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Skip classical function tests if tweedledum isn't present This commit fixes an oversight in #8849 and #8818 which made tweedledum optional for arm64 macOS systems which was the unittest suite still unconditionally depends on tweedledum being installed to run the classical function compiler tests. This commit fixes this by making the tests skip if tweedledum isn't installed so that M1 mac users are able to run the full test suite again. * Skip other tests requiring tweedledum
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Skip classical function tests if tweedledum isn't present This commit fixes an oversight in #8849 and #8818 which made tweedledum optional for arm64 macOS systems which was the unittest suite still unconditionally depends on tweedledum being installed to run the classical function compiler tests. This commit fixes this by making the tests skip if tweedledum isn't installed so that M1 mac users are able to run the full test suite again. * Skip other tests requiring tweedledum (cherry picked from commit 75fe9bb)
mergify bot
added a commit
that referenced
this pull request
Oct 12, 2022
) * Skip classical function tests if tweedledum isn't present This commit fixes an oversight in #8849 and #8818 which made tweedledum optional for arm64 macOS systems which was the unittest suite still unconditionally depends on tweedledum being installed to run the classical function compiler tests. This commit fixes this by making the tests skip if tweedledum isn't installed so that M1 mac users are able to run the full test suite again. * Skip other tests requiring tweedledum (cherry picked from commit 75fe9bb) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Skip classical function tests if tweedledum isn't present This commit fixes an oversight in Qiskit#8849 and Qiskit#8818 which made tweedledum optional for arm64 macOS systems which was the unittest suite still unconditionally depends on tweedledum being installed to run the classical function compiler tests. This commit fixes this by making the tests skip if tweedledum isn't installed so that M1 mac users are able to run the full test suite again. * Skip other tests requiring tweedledum
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
…kit#8876) * Skip classical function tests if tweedledum isn't present This commit fixes an oversight in Qiskit/qiskit#8849 and Qiskit/qiskit#8818 which made tweedledum optional for arm64 macOS systems which was the unittest suite still unconditionally depends on tweedledum being installed to run the classical function compiler tests. This commit fixes this by making the tests skip if tweedledum isn't installed so that M1 mac users are able to run the full test suite again. * Skip other tests requiring tweedledum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In gh-8818 we prevented macOS arm64 from attempting to use tweedledum 1.1.1 as no arm64 wheels are supplied for that version. In fact, the "arm64" and "universal2" wheels supplied for 1.1.0 are actually mislabelled x86_64 wheels as well, and so there is no working binary version of tweedledum for arm64, and the sdist build process works only rarely for most people.
Since the work of gh-8738 makes
tweedledumeffectively optional forimport qiskitwith immediate effect, and the only way to have a working installation on M1 mac is essentially to have already manually builttweedledumfrom source, the effects of immediately removing the requirement from arm64 macs only should be very slight at worst, and a good quality of life improvement for normal M1 users.Details and comments
See also #8716 (comment) and next reply.