Fix loose-bit handling in QPY #8928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typo in clbit-reconstruction was generating the incorrect number of loose clbits in circuits that contained registers and loose bits, and had more qubits than clbits. A bug elsewhere in the code caused circuits with _no_ registers to be deserialised as containing registers, since the `QuantumCircuit(int, int)` constructor actually does produce two registers (slightly surprisingly, perhaps).
jakelishman
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
approved these changes
Oct 17, 2022
Pull Request Test Coverage Report for Build 3267096159
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
A typo in clbit-reconstruction was generating the incorrect number of loose clbits in circuits that contained registers and loose bits, and had more qubits than clbits. A bug elsewhere in the code caused circuits with _no_ registers to be deserialised as containing registers, since the `QuantumCircuit(int, int)` constructor actually does produce two registers (slightly surprisingly, perhaps). (cherry picked from commit c34e0b9)
mergify bot
added a commit
that referenced
this pull request
Oct 17, 2022
A typo in clbit-reconstruction was generating the incorrect number of loose clbits in circuits that contained registers and loose bits, and had more qubits than clbits. A bug elsewhere in the code caused circuits with _no_ registers to be deserialised as containing registers, since the `QuantumCircuit(int, int)` constructor actually does produce two registers (slightly surprisingly, perhaps). (cherry picked from commit c34e0b9) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
ajavadia
pushed a commit
to ajavadia/qiskit
that referenced
this pull request
Oct 18, 2022
A typo in clbit-reconstruction was generating the incorrect number of loose clbits in circuits that contained registers and loose bits, and had more qubits than clbits. A bug elsewhere in the code caused circuits with _no_ registers to be deserialised as containing registers, since the `QuantumCircuit(int, int)` constructor actually does produce two registers (slightly surprisingly, perhaps).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A typo in clbit-reconstruction was generating the incorrect number of loose clbits in circuits that contained registers and loose bits, and had more qubits than clbits. A bug elsewhere in the code caused circuits with no registers to be deserialised as containing registers, since the
QuantumCircuit(int, int)constructor actually does produce two registers (slightly surprisingly, perhaps).Details and comments