Relax constraints on jupyter-core and ipywidgets #9364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were originally added in Qiskit#9105 and Qiskit#9272 respectively, but the original problem package `seaborn` has released since then, which may have fixed things.
jakelishman
added
type: qa
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
1ucian0
previously approved these changes
Jan 12, 2023
Pull Request Test Coverage Report for Build 3904193432
💛 - Coveralls |
|
This doesn't fix the |
This removes some now-unnecessary suppressions from image-related packages, and adds the new suppression for the pyzmq problem, which is Jupyter's domain to handle. The extra environment variable in the images test run is to eagerly move to new default behaviour starting in jupyter-core 6; there is no need for us to pin the package too low, since this warning is just encouraging people to proactively test the new behaviour, and it doesn't cause our suite problems.
One day I'll remember this when writing environment variables in YAML files, but it's not this day.
jakelishman
added
the
stable backport potential
mtreinish
approved these changes
Jan 12, 2023
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Jan 12, 2023
These were originally added in Qiskit#9105 and Qiskit#9272 respectively, but the original problem package `seaborn` has released since then, which may have fixed things. This removes some now-unnecessary suppressions from image-related packages, and adds the new suppression for the pyzmq problem, which is Jupyter's domain to handle. The extra environment variable in the images test run is to eagerly move to new default behaviour starting in jupyter-core 6; there is no need for us to pin the package too low, since this warning is just encouraging people to proactively test the new behaviour, and it doesn't cause our suite problems.
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Jan 12, 2023
These were originally added in Qiskit#9105 and Qiskit#9272 respectively, but the original problem package `seaborn` has released since then, which may have fixed things. This removes some now-unnecessary suppressions from image-related packages, and adds the new suppression for the pyzmq problem, which is Jupyter's domain to handle. The extra environment variable in the images test run is to eagerly move to new default behaviour starting in jupyter-core 6; there is no need for us to pin the package too low, since this warning is just encouraging people to proactively test the new behaviour, and it doesn't cause our suite problems.
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Jan 12, 2023
These were originally added in Qiskit#9105 and Qiskit#9272 respectively, but the original problem package `seaborn` has released since then, which may have fixed things. This removes some now-unnecessary suppressions from image-related packages, and adds the new suppression for the pyzmq problem, which is Jupyter's domain to handle. The extra environment variable in the images test run is to eagerly move to new default behaviour starting in jupyter-core 6; there is no need for us to pin the package too low, since this warning is just encouraging people to proactively test the new behaviour, and it doesn't cause our suite problems.
Merged
mtreinish
removed
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
* Fix NumPy 1.24.0 compatibility and pin `coverage<7.0` (#9305) * fix Kraus from (array, None) * fix triu_to_dense test * fix instruction comparison * skip snobfit if numpy 1.24.0 or above is installed Co-authored-by: ElePT <57907331+ElePT@users.noreply.github.com> * pin coverage <7.0 * add links to Kraus and snobfit issues * retrigger CI Co-authored-by: ElePT <57907331+ElePT@users.noreply.github.com> (cherry picked from commit 9733fc0) * Update `qiskit.utils.wrap_method` for Python 3.11 (#9310) * Revert "[Test] Pin maximum python version in CI to <3.11.1 (#9296)" This reverts commit 07e0a2f. * Do not treat __init_subclass__ as a special type method * Release note * Apply suggestions from code review Co-authored-by: Julien Gacon <gaconju@gmail.com> * Use inspect.getattr_static to bypass descriptor call * Update release note * Update wrap_method test * Adjust wording on release note Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 0344a1c) * Relax constraints on jupyter-core and ipywidgets (#9364) These were originally added in #9105 and #9272 respectively, but the original problem package `seaborn` has released since then, which may have fixed things. This removes some now-unnecessary suppressions from image-related packages, and adds the new suppression for the pyzmq problem, which is Jupyter's domain to handle. The extra environment variable in the images test run is to eagerly move to new default behaviour starting in jupyter-core 6; there is no need for us to pin the package too low, since this warning is just encouraging people to proactively test the new behaviour, and it doesn't cause our suite problems. * Refactor coverage CI workflow (#9361) This relaxes the constraint on `coverage` added in #9305. The issue there is actually the now unmaintained `coveragepy-lcov` package is not compatible with Coverage.py 7.0. However, we only needed `coveragepy-lcov` to convert Coverage's format into LCOV, which is a feature Coverage has had itself since version 6.0. This commit also updates some parts of the coverage workflow that were old: - there are new versions of the Actions `checkout` and `setup-python`, which swap to using Node 16 rather than Node 12, which is deprecated in GHA - `grcov` is packaged and installable from `cargo` now, rather than needing a manual hard-coded pull from GitHub - we can have `grcov` only keep the parts we care about immediately, rather than converting everything and later discarding it Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 7955d92) Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These were originally added in #9105 and #9272 respectively, but the original problem package
seabornhas released since then, which may have fixed things.Details and comments
If this isn't sufficient, we can consider adding manual suppressions instead; the various parts of the Jupyter stack in the past have shown some apathy towards fixing warnings being emitted from low-level packages if they wouldn't be displayed to users by default, so the wait for fixes can be long.