Change algorithms from pending deprecate to deprecate

[manoelmarques]

Summary

Details and comments

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core
• @manoelmarques
• @woodsp-ibm

[coveralls]

Pull Request Test Coverage Report for Build 4188603180

• 77 of 78 (98.72%) changed or added relevant lines in 23 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.008%) to 85.283%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/utils/deprecation.py	14	15	93.33%

Totals
Change from base Build 4188491363:	0.008%
Covered Lines:	67251
Relevant Lines:	78856

---

💛 - Coveralls

[woodsp-ibm]

Needs care when conflicts are resolved to include the url to migration guide again and the version since deprecation will need to be 0.24.0 (#9616 was the cause of the conflicts)

[Eric-Arellano]

Needs care when conflicts are resolved to include the url to migration guide again and the version since deprecation will need to be 0.24.0 (#9616 was the cause of the conflicts)

I will push a commit today to fix the merge conflicts to clean up after myself :) My understanding from #9616 (comment) was that we didn't want me to make the change to Deprecated in that PR.

[woodsp-ibm]

Thanks in advance! That comment was more that the pending deprecation has been in place since 0.22. It now says 0.23,, not that it matters really since this PR will override that yet again to make it since deprecation.

I imagine this will all need fixing up too #9176 - which is the deprecating the logic that the deprecated algorithms relied on for the transition over to primitives.

[woodsp-ibm]

Closing as superseded by #9883 which has now been completed and merged.