-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix classical-synthesis label ordering with registerless=False
#9536
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5868913929
💛 - Coveralls |
registerless=False
from qiskit.circuit.classicalfunction import classical_function | ||
from qiskit.circuit.classicalfunction.types import Int1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweedledum isn't a required import, so these lines need to be protected within the function, and it needs decorating with a @unittest.skipUnless(optionals.HAS_TWEEDLEDUM, ...)
line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! I forgot. Thanks! Fixed in 91069ad
Fixed `#9363 <https://github.com/Qiskit/qiskit-terra/issues/9363>`__. | ||
by labeling the non-registerless synthesis in the order that Tweedledum expects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could maybe stand a shade more explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Adding more in 232e4e5
ClassicalFunctionCompilerError: If there a gate in the Tweedledum circuit has no Qiskit | ||
ClassicalFunctionCompilerError: If there is a gate in the Tweedledum circuit has no Qiskit | ||
equivalent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's either "If there is a gate in the Tweedledum circuit that has no ..." or just delete at the start to make it "If a gate in ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in aa04278
* follow the Tweedledum convention on endianness * reno * add test * optional dep * docstring * reno * attempt to fix sphinx --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> (cherry picked from commit 287ac5c)
…kit#9536) * follow the Tweedledum convention on endianness * reno * add test * optional dep * docstring * reno * attempt to fix sphinx --------- Co-authored-by: Julien Gacon <gaconju@gmail.com>
Fixes #9363