Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new deprecation decorators to util files and folders #9875

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Apply new deprecation decorators to util files and folders #9875

merged 1 commit into from
Mar 30, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

Summary

See #9676 for the motivation.

Details and comments

@Eric-Arellano Eric-Arellano added the Changelog: None Do not include in changelog label Mar 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4555628951

  • 15 of 15 (100.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 85.354%
Files with Coverage Reduction New Missed Lines %
qiskit/test/decorators.py 1 67.2%
Totals Coverage Status
Change from base Build 4552100985: 0.007%
Covered Lines: 67100
Relevant Lines: 78614
💛 - Coveralls

@Eric-Arellano Eric-Arellano marked this pull request as ready for review March 29, 2023 20:48
1ucian0
1ucian0 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1ucian0 1ucian0 added this pull request to the merge queue Mar 30, 2023
@1ucian0 1ucian0 added the type: qa Issues and PRs that relate to testing and code quality label Mar 30, 2023
Merged via the queue into Qiskit:main with commit 2cf7704 Mar 30, 2023
@Eric-Arellano Eric-Arellano deleted the apply-deprecations-utils branch March 30, 2023 11:39
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Apr 5, 2023
@Eric-Arellano @ElePT
Apply new deprecation decorators to util files and folders (Qiskit#9875)
c943ccc
giacomoRanieri pushed a commit to giacomoRanieri/qiskit-terra that referenced this pull request Apr 16, 2023
@Eric-Arellano @giacomoRanieri
Apply new deprecation decorators to util files and folders (Qiskit#9875)
1c5f2bd
@jakelishman jakelishman mentioned this pull request Apr 19, 2023
Closed
10 tasks
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
@Eric-Arellano @king-p3nguin
Apply new deprecation decorators to util files and folders (Qiskit#9875)
6973817
ElePT pushed a commit to ElePT/qiskit-algorithms that referenced this pull request Jul 27, 2023
@Eric-Arellano
Apply new deprecation decorators to util files and folders (Qiskit/qi…
0d1a2ee 
…skit#9875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 approved these changes

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii alexanderivrii is a code owner

@ShellyGarion ShellyGarion Awaiting requested review from ShellyGarion ShellyGarion is a code owner

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm

@ikkoham ikkoham Awaiting requested review from ikkoham

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eric-Arellano @coveralls @1ucian0