Deprecate circuit-library Jupyter magic #9940
Conversation
This has not been used since the switch away from using `jupyter-execute` in Qiskitgh-9346, so is neither maintained nor necessary. Any improvements to styling should be made to the new paths, not to these. These objects were originally intended only for the documentation so we expect user impact to be minimal, and the objects are not maintained anyway.
jakelishman
added
the
Changelog: Deprecation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
Oh yeah, I forgot about the freeze - I've put the wrong version in all the On another note: I checked Paul's blog (expecting that to be the most likely place the magic might still be used), and it's not there. |
Pull Request Test Coverage Report for Build 4669473687
💛 - Coveralls |
* Deprecate circuit-library Jupyter magic This has not been used since the switch away from using `jupyter-execute` in Qiskitgh-9346, so is neither maintained nor necessary. Any improvements to styling should be made to the new paths, not to these. These objects were originally intended only for the documentation so we expect user impact to be minimal, and the objects are not maintained anyway. * Correct versions for deprecation * Add missing import
Summary
This has not been used since the switch away from using
jupyter-executein gh-9346, so is neither maintained nor necessary. Any improvements to styling should be made to the new paths, not to these. These objects were originally intended only for the documentation so we expect user impact to be minimal, and the objects are not maintained anyway.Details and comments
These are the only direct users of the Pygments lexer that caused us problems that needed a fix in #9938. We planned to deprecate these in #9346 (comment), but we failed to follow up on it at the time.