-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reorganize to allow theme variants (#216)
## Summary We plan to add variants of the Sphinx theme so that we can differentiate between Core vs the Ecosystem. They'll be distributed in the same package, and users only need to choose the `html_theme` in their `conf.py`. They will also share a "base" theme and override the CSS/images/HTML templates they care about. See #215 for an example of this. This PR reorganizes our folder structure so that we can add variants in followup PRs. ## Details We call the folder `pytorch_base` because we likely will want Pytorch-based variants for Core vs Ecosystem, and they'll use this folder as their base. Those variants will be added in follow ups. This also simplifies our `MANIFEST.in` and `setup.py` with @jakelishman's recommendation from #212 (review). The benefit of that is we make fewer changes when adding new theme variants (we have to add `graft qiskit_sphinx_theme/<variant>/static` to MANIFEST.in). I verified this works by using `python -m build` and inspecting the RECORD of the wheel, which shows the contents.
- Loading branch information
1 parent
f18d9a7
commit 664df20
Showing
30 changed files
with
14 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
include qiskit_sphinx_theme/theme.conf | ||
include qiskit_sphinx_theme/*.html | ||
include qiskit_sphinx_theme/static/css/*.css | ||
include qiskit_sphinx_theme/static/js/*.js | ||
include qiskit_sphinx_theme/static/images/*.* | ||
recursive-include qiskit_sphinx_theme *.html | ||
recursive-include qiskit_sphinx_theme theme.conf | ||
graft qiskit_sphinx_theme/pytorch_base/static |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters