Remove references to some missing files and fix some invalid JavaScript #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-console-errors
Eric-Arellano
added a commit
that referenced
this pull request
May 17, 2023
Closes #335. I git bisected this to #292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
Eric-Arellano
added a commit
to Eric-Arellano/qiskit_sphinx_theme
that referenced
this pull request
May 17, 2023
Closes Qiskit#335. I git bisected this to Qiskit#292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
HuangJunye
pushed a commit
that referenced
this pull request
May 18, 2023
Closes #335. I git bisected this to #292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js/vendor, which was removed in remove vendor js code #17css.theme.map, which we never distribute since we never minifycss.themeto begin withpytorch-shortcuts-wrapperandheader-holder, which no longer exist in our HTML template and caused the JavaScript to fail to run.The main console error I still get is tracked by #291. (FYI: to avoid a bunch of console errors when developing, you need to serve the app with e.g.
python3 -m http.server, rather than openingindex.htmldirectly.)As a result of this change, the right page table of contents now shows subheadings! You can click the + or - to expand it.