Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Furo styling to qiskit-call-to-action-item #434

Merged
merged 12 commits into from
Jun 30, 2023
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Jun 29, 2023

Closes #327.

This uses an extremely similar style to Pytorch:

pytorch-cats

It's main change is using our color variables. The padding is also a little less intense.

The icon implementation is awkward, but I couldn't figure out how to reuse the icon from icons.html easily because we still need to support Pytorch. So, I went with this implementation and opened #433 to improve it once we drop Pytorch.

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Eric-Arellano Eric-Arellano merged commit 76ae1e8 into main Jun 30, 2023
4 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/furo-cat branch June 30, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Furo: ensure it properly formats custom directives
2 participants