Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off CI for pushes #565

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

We use GitHub branch protection to require opening a PR for main and the 1.* branches; you cannot push directly. For main, we also require that CI runs against the latest main.

So, there is no need to run CI again for pushes since it already runs with PRs. Don't waste compute resources, which have a real environmental cost.

Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a minor question. Nice branch name 🌲

- main
- '1.*'
pull_request:
on: [pull_request]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just on: pull_request?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't realize it could be that. Seems fine either way though

@Eric-Arellano Eric-Arellano merged commit cd83109 into Qiskit:main Sep 15, 2023
5 checks passed
@Eric-Arellano Eric-Arellano deleted the save-the-trees branch September 15, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants