Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump furo to 2024.1.29 #594

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

airwoodix
Copy link
Contributor

@airwoodix airwoodix commented Feb 26, 2024

Update furo from 2023.8.19 to 2024.1.29. Resolves #567.

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@airwoodix
Copy link
Contributor Author

@Eric-Arellano would you have hints whether bumping the version is sufficient? It'd be nice to get a dependency on a non-yanked furo release released, since stricter resolvers, e.g. uv, treat yanked releases as incompatible, making it cumbersome to install qiskit-sphinx-theme (works with an override but is not convenient). Thanks!

@Eric-Arellano
Copy link
Collaborator

Hey @airwoodix, pardon the delay on this and thank you for taking the initiative with creating this PR. I appreciate it!

This looks good and you followed the correct process at

### How to update the Furo version
Update the version in `pyproject.toml`. Always pin to an exact version of Furo.
However, when updating, closely analyze each commit in the release to check for any changes that would break our fork. We want to make sure that our HTML files are always in sync with Furo. If they have made any changes, then add them back to our copy of the file.

We're not ready for a 2.0 release because it makes some breaking changes we haven't finished. So I will make a 1.16 patch release with this cherry-picked.

@Eric-Arellano Eric-Arellano changed the title deps: bump furo to 2023.9.10 deps: bump furo to 2024.1.29 Mar 1, 2024
@Eric-Arellano Eric-Arellano merged commit 9fd9765 into Qiskit:main Mar 1, 2024
5 checks passed
Eric-Arellano pushed a commit to Eric-Arellano/qiskit_sphinx_theme that referenced this pull request Mar 1, 2024
Update `furo` from 2023.8.19 to 2024.1.29. Resolves Qiskit#567.
Eric-Arellano added a commit that referenced this pull request Mar 1, 2024
Update `furo` from 2023.8.19 to 2024.1.29. Resolves #567.

Co-authored-by: Etienne Wodey <44871469+airwoodix@users.noreply.github.com>
@Eric-Arellano
Copy link
Collaborator

@airwoodix qiskit-sphinx-theme 1.16.1 is released. Thanks again for your help!

@airwoodix
Copy link
Contributor Author

Thanks for the merge and the extra release! Glad to see that a newer furo release works fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned furo release has been yanked
3 participants