Enable dark mode #613
Merged
Enable dark mode #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsung
force-pushed
the
dark-mode
branch
2 times, most recently
from
828a552
to
05b5486
Compare
|
Consider having the icons change be a dedicated precursor PR. For dark mode, I think it's plausible we'll want visual regression testing for possibly everything, or at least most of them, in dark mode. That's a big PR, so it's useful to split out "prefactors" (refactors as precursors) |
kevinsung
force-pushed
the
dark-mode
branch
4 times, most recently
from
fc9447a
to
02bee9e
Compare
|
@Eric-Arellano PTAL. Jupyter looks bad but I don't know if there's a good way to fix that or if it's within the scope of this PR. Furo suffers from the same issue. See jupyter/jupyter-sphinx#218. |
tests/js/tests.js-snapshots/admonitions-use-Carbon-style-dark-mode-1-linux.png
Outdated
Show resolved
Hide resolved
|
CI failure seems unrelated. It's been consistently happening for the past half hour or so though. |
|
@kevinsung this all looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575.
Replaces the existing Carbon icons with different SVGs that are more easily adapted for dark mode by replacing the fill with
"currentColor".TODO: