Add is_maximal_matching and is_matching functions #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
force-pushed
the
matching-functions
branch
from
46f6f01 to
e5eb0c4
Compare
This commit adds new functions for checking a provided matching set is valid, is_matching(), and that a provided matching set is valid and maximal, is_maximal_set(). This pairs with Qiskit#229 and can be used to partially check the output from the max_weight_matching function added there. Equivalent functions were implemented in Qiskit#229 using Python for the tests in Qiskit#229 and those tests should be updated to use these functions instead. Fixes Qiskit#255
mtreinish
force-pushed
the
matching-functions
branch
from
e5eb0c4 to
05c7123
Compare
Pull Request Test Coverage Report for Build 610828102
💛 - Coveralls |
itoko
requested changes
Mar 1, 2021
The original implementation was based on networkx's which was getting all the combinations of edges in the matching and checking for unique endpoints on all those pairs. However, doing the combinations adds extra complexity when we can just flatten the input matching to a set of endpoints and if aduplicate is found it's not a valid matching. This commit updates the inner is_matching function to make this change which simplifies the code and should be faster. Co-authored-by: Toshinari Itoko <itoko@jp.ibm.com>
itoko
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new functions for checking a provided matching set is
valid, is_matching(), and that a provided matching set is valid and
maximal, is_maximal_set(). This pairs with #229 and can be used to
partially check the output from the max_weight_matching function added
there. Equivalent functions were implemented in #229 using Python for
the tests in #229 and those tests should be updated to use these
functions instead.
Fixes #255