You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately there are a number of breaking changes and deprecations we
will have to update our usage to account for. This commit starts the
process by fixing the compiler errors due to changes in behavior a
subsequent commit will address the deprecation warnings.
This commit updates pyo3 and numpy to the latest release 0.16.0. The
details on these releases can be found here:
https://pyo3.rs/v0.16.0/changelog.html
and
https://github.com/PyO3/rust-numpy/blob/main/CHANGELOG.md
Unfortunately there are a number of breaking changes and deprecations we
will have to update our usage to account for. This commit starts the
process by fixing the compiler errors due to changes in behavior a
subsequent commit will address the deprecation warnings.
Deprecate the #[pyproto] traits. (https://github.com/PyO3/pyo3/pull/2173)
I think that will be the most amount of work from moving to PyO3 0.16 as most of our custom return types use #[pyproto]. The removal is only going to happen around the PyO3 0.18 release, but it would good to move from #[pyproto] to #[pymethod] before that.
Yeah, that's what my next step was to tackle all of those pyproto deprecation warnings. They will fail the clippy run in ci without fixing all the deprecation warnings (it's why I tagged it on hold). But I wanted to push up what I had after tracking down all the private pyfunctions.
Yeah, that's what my next step was to tackle all of those pyproto deprecation warnings. They will fail the clippy run in ci without fixing all the deprecation warnings (it's why I tagged it on hold). But I wanted to push up what I had after tracking down all the private pyfunctions.
We can temporarily use #![allow(deprecated)] (along the lines of PyO3/pyo3#2173) and open a separate issue to migrate away from #[pyproto]
I just pushed 58ab94e to fix pyproto deprecation warnings. For the most part the changes were straightforward. I just had to redefine our own version of the deprecated pyo3::gc::PyGCProtocol since it's the most convenient way to adjust the behavior of each class regarding garbage collection.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates pyo3 and numpy to the latest release 0.16.0. The
details on these releases can be found here:
https://pyo3.rs/v0.16.0/changelog.html
and
https://github.com/PyO3/rust-numpy/blob/main/CHANGELOG.md
Unfortunately there are a number of breaking changes and deprecations we
will have to update our usage to account for. This commit starts the
process by fixing the compiler errors due to changes in behavior a
subsequent commit will address the deprecation warnings.