-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cycle_graph generator to rustworkx-core #758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the cycle-graph generator to rustworkx-core. It makes the function generic so that it can be used with any petgraph graph that's buildable and node indexable. This is primarily to serve as a pattern for migrating all the generator functions we currently have to rustworkx-core. This pattern should be usable for any generator function we have. Part of Qiskit#751
mtreinish
force-pushed
the
migrate-generators
branch
from
December 12, 2022 14:42
945743d
to
efef631
Compare
mtreinish
changed the title
[WIP] Move cycle_graph generator to rustworkx-core
Move cycle_graph generator to rustworkx-core
Dec 12, 2022
Pull Request Test Coverage Report for Build 3850211525
💛 - Coveralls |
This was referenced Jan 4, 2023
IvanIsCoding
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, it is a good framework to migrate the generators. I just made a minor suggestion on imports to avoid having to import every generator by hand given we will have a large amount.
mtreinish
commented
Jan 5, 2023
Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
This was referenced Jan 5, 2023
This was referenced Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the cycle-graph generator to rustworkx-core. It makes the function generic so that it can be used with any petgraph graph that's buildable and node indexable. This is primarily to serve as a pattern for migrating all the generator functions we currently have to rustworkx-core. This pattern should be usable for any generator function we have.
Part of #751
TODO: