-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct versions of 4 generators #785
Conversation
Pull Request Test Coverage Report for Build 3925466615
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am against this getting merged because the directed version of some of the graphs you proposed are not common or useful. I will take for example the Generalized Petersen graph, but it also applies to the others.
By definition the graph is undirected. Almost all of the literature about the graph is about it being undirected and its properties that are related to that. Why would we generate a graph that people don't use? It misses the point of why generators exist.
If someone ever needs the topology of some of the graphs and needs to change from undirected to directed, they can call to_directed()
and it works. So I'd rather not merge this
Thanks for the feedback, Ivan. I was only doing it for consistency reasons and if they're not needed, best not to add them. I'll close this. |
Fixes #751.
This PR adds directed versions of the lollipop, barbell, full_rary_tree, and petersen generators. It's based on #784, and should be merged after that one.