Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define license on pypi #124

Open
Kreyren opened this issue Oct 29, 2022 · 3 comments
Open

Define license on pypi #124

Kreyren opened this issue Oct 29, 2022 · 3 comments

Comments

@Kreyren
Copy link

Kreyren commented Oct 29, 2022

Define the license for this project on pypi so that it can be automated e.g. package import by guix users

kreyren@dreamon ~$ guix import pypi better-exceptions

Starting download of /tmp/guix-file.HIExkY
From https://files.pythonhosted.org/packages/26/d8/30b745b965765c08ee132fd590fca46c31296e8f1a606de0c53cc6b5a68f/better_exceptions-0.3.3.tar.gz...
 …ns-0.3.3.tar.gz  29KiB              2.6MiB/s 00:00 [##################] 100.0%

Starting download of /tmp/guix-file.O3ArzJ
From https://files.pythonhosted.org/packages/ed/50/abf6850135f1e95d321a525d0a36e05255a039b3fc118b7d88413e8a8207/better_exceptions-0.3.3-py3-none-any.whl...
 …3.3-py3-none-any.whl  12KiB         2.6MiB/s 00:00 [##################] 100.0%
guix import: warning: Failed to extract file: better_exceptions-0.3.3.dist-info/METADATA from wheel.
(package
  (name "python-better-exceptions")
  (version "0.3.3")
  (source (origin
            (method url-fetch)
            (uri (pypi-uri "better_exceptions" version))
            (sha256
             (base32
              "0fs5nfg7xdbx5hb1h1148kax68g9wn0h7cclx3k08psd8hcbrrp4"))))
  (build-system python-build-system)
  (home-page "https://github.com/qix-/better-exceptions")
  (synopsis "Pretty and helpful exceptions, automatically")
  (description "Pretty and helpful exceptions, automatically")
  # required field (license license:expat) missing due to it not being defined in pypi
@Qix-
Copy link
Owner

Qix- commented Nov 3, 2022

PR Welcome :)

Qix- pushed a commit that referenced this issue Dec 2, 2022
@dus7eh
Copy link

dus7eh commented Mar 18, 2024

Merged PR doesn't seem to fix the issue. Still when you download the released package metadata file contains the following entry:
License: UNKNOWN

Similarly, proper license isn't shown in pypi: https://pypi.org/project/better-exceptions/

@reneleonhardt
Copy link

@dus7eh you're right, I suggest filling classifiers, i.e.:

classifiers = [
  "License :: OSI Approved :: MIT License"
],

Maybe explicitly clearing it like now (classifiers = []) prevents setuptools from using the license = 'MIT' metadata...
https://github.com/Qix-/better-exceptions/blob/master/setup.py#L65
https://docs.python.org/3.11/distutils/setupscript.html#additional-meta-data

classifiers example:
https://github.com/Delgan/loguru/blob/master/pyproject.toml#L14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants