-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shadowed models variable #49
Conversation
Aha! Just saw this too! https://github.com/Qix-/color-convert/issues/50 |
Getting this in a production React Native build as well |
just rename the first one to MODELS, instead of moving it in the function edit: nvm, it's just using Object.keys it's fine |
@Qix- can you please accept it? It is very important since UglifyES break production websites. |
Hey sorry for the delay - was afk for my birthday. Good catch :) Thanks for the PR. |
Released as |
Unfortunately Edit: and thank you for fixing quickly. |
@natew If you use yarn you can override this version in your package.json And/or raise an issue in 'color' |
Created this PR https://github.com/Qix-/color/pull/133 |
Thanks again :) |
Models is re-declared on line 81 of
route.js
which was causing webpack's uglification/optimisation to throw errors in prod builds.I have moved the first models to the
buildGraph
scope which fixes the issue as theconversions
models was only ever used in that function.Closes #50