Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color-string incorrectly believes prototype properties are colors #44

Closed
tolmasky opened this issue Jul 17, 2019 · 1 comment
Closed

color-string incorrectly believes prototype properties are colors #44

tolmasky opened this issue Jul 17, 2019 · 1 comment

Comments

@tolmasky
Copy link
Contributor

tolmasky commented Jul 17, 2019 •
edited
Loading

color-string will incorrectly return a color object for things like "constructor" and "__proto__".

Here is an example of all of them:

Screen Shot 2019-07-17 at 9 21 08 AM

https://runkit.com/tolmasky/color-string-prototype-bug

If one adds other properties to Object.prototype, those will also be mis-identified as colors.
tolmasky added a commit to runkit-forks/color-string that referenced this issue Jul 17, 2019
@tolmasky
Fix issue where color-string with incorrectly return a color for prop…
ab34443 
…erties on Object's prototype like "constructor".

Closes Qix-#44.

Reviewed by @tolmasky.
@tolmasky tolmasky mentioned this issue Jul 17, 2019
Closed
@Qix-
Copy link
Owner

Qix- commented Nov 26, 2021

Great catch. Thanks for the repo, and sorry for the insane delay on this.

Qix- added a commit that referenced this issue Nov 26, 2021
@Qix-
add failing test for #44
b7c685f
@Qix- Qix- closed this as completed in 20e55f3 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tolmasky @Qix-