Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-save resources #52

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

epergo
Copy link
Contributor

@epergo epergo commented Jun 24, 2023

Hi! I've gone through every resource and manually saved them again using Godot version 4.0.3, so the resource definition gets updated to the format used nowadays.

In my tests, this doesn't fully fix the build_def_text error that sometimes happen, but I think is needed nonetheless.


[resource]
script = ExtResource("6")
export_file = false
target_folder = "C:/OtherPrograms/TrenchBroom/games/Qodot"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this to be an empty string because each user will potentially have a different path. WDYT? Should I keep it like it was before?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually seperate changes like this should be seperate PRs but it's all good! Makes sense.

@EMBYRDEV EMBYRDEV merged commit 763a438 into QodotPlugin:main Jun 26, 2023
@EMBYRDEV
Copy link
Collaborator

Thanks!

@epergo epergo deleted the ep/force-save-resources branch June 29, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants