Added protection in dp_compile
#129
Conversation
| delta: f64, | ||
| ) -> Result<(PEPRelation, PrivateQuery)> { | ||
| Ok( | ||
| if self.grouping_columns()? == vec![protected_entity_id.to_string()] { |
There was a problem hiding this comment.
Why is this a special case ?
There was a problem hiding this comment.
because the self is a PEPRelation so that we have added PE_ID in the grouping columns
And by definition we cannot reveal the keys with only one PE_ID value
| Expr::eq( | ||
| Expr::qcol(self.name().to_string(), f.name().to_string()), | ||
| Expr::qcol(grouping_values.name().to_string(), f.name().to_string()), | ||
| pub fn protect_grouping_keys( |
There was a problem hiding this comment.
What does this function do ? pease document
There was a problem hiding this comment.
We are not protecting anything, what's the purpose of this ?
| epsilon: f64, | ||
| delta: f64, | ||
| ) -> Result<(PEPRelation, PrivateQuery)> { | ||
| let (protected_input, private_query) = PEPRelation::try_from(self.inputs()[0].clone())? |
There was a problem hiding this comment.
The whole point of having types for PEP and DP is to have compile time guarantees, you are defeating this point everywhere you use runtime failible conversions.
| delta: f64, | ||
| ) -> Result<(PEPRelation, PrivateQuery)> { | ||
| let (protected_input, private_query) = PEPRelation::try_from(self.inputs()[0].clone())? | ||
| .protect_grouping_keys(epsilon, delta)?; |
There was a problem hiding this comment.
It seems that you are visiting the Relation without really doing it.
Are you sure your code will not process the input of an autojoin twice ?
| ) -> Result<(PEPRelation, PrivateQuery)> { | ||
| let (left_dp_relation, left_private_query) = | ||
| PEPRelation::try_from(self.inputs()[0].clone())? | ||
| .protect_grouping_keys(epsilon, delta)?; |
There was a problem hiding this comment.
Are you sure you are not processing the same relation twice?
Can you add a test for this case ?
No description provided.