implemented var and std #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2023 09:23
ngrislain
reviewed
Dec 5, 2023
| @@ -150,6 +150,10 @@ impl PUPRelation { | |||
| let one_col = format!("_ONE_{}", col_name); | |||
| let sum_col = format!("_SUM_{}", col_name); | |||
| let count_col = format!("_COUNT_{}", col_name); | |||
| let square_col = format!("_SQUARE_{}", col_name); | |||
| let one_square_col = format!("_ONE_{}", square_col); | |||
There was a problem hiding this comment.
Pourquoi a-t-on besoin d'un one différent ?
There was a problem hiding this comment.
parce que l'on veut deux counts bruités différents dans l'estimateur
ngrislain
reviewed
Dec 7, 2023
| let square_col = format!("_SQUARE_{}", col_name); | ||
| let one_square_col = format!("_ONE_{}", square_col); | ||
| let sum_square_col = format!("_SUM_{}", square_col); | ||
| let count_square_col = format!("_COUNT_{}", square_col); |
There was a problem hiding this comment.
Dis moi quand tu as pu supprimer cela
ngrislain
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.