Fix bug when using the same column in the GROUP BY and an Aggregate function #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vserret
commented
Dec 15, 2023
| @@ -166,31 +166,6 @@ impl Reduce { | |||
| self | |||
| } | |||
|
|
|||
| /// Clip all sums in the `Reduce` | |||
There was a problem hiding this comment.
legacy code. not used
ngrislain
reviewed
Dec 15, 2023
| /// Field names of the output `Relation`: | ||
| /// - If the aggregation is `First`, the field name is the name of the column. | ||
| /// - If the aggregation is `Sum`, the field name is the first element of the corresponding tuple in the `values` parameter. | ||
| pub fn sums_by_group(self, groups: Vec<&str>, values: Vec<(&str, &str)>) -> Self { |
ngrislain
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.