compose relations #266
Merged
compose relations #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngrislain
reviewed
Feb 15, 2024
src/rewriting/composition.rs
Outdated
| /// The output relations will have the same paths as the outer_relations | ||
| /// Tables in the outer_relations should have a compatible schema with | ||
| /// inner_relations otherwise an error is raised. | ||
| pub fn compose_relations<'a>( |
There was a problem hiding this comment.
Why not make this a method of Hierarchy<Arc<Relation>>?
Can't you implement this
impl Hierarchy<Arc<Relation>> {
pub fn compose()...
}
in this module ?
There was a problem hiding this comment.
ok, Implemented Hierarchy<Arc<Relation>> with the compose method.
ngrislain
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.