Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDS-617] Fix measurement statements in ProjectQ #143

Merged
merged 2 commits into from
Jun 28, 2022
Merged

[SDS-617] Fix measurement statements in ProjectQ #143

merged 2 commits into from
Jun 28, 2022

Conversation

QFer
Copy link
Contributor

@QFer QFer commented Jun 21, 2022 •
edited
Loading

  • Added measurement statements in projectQ algorithm at the end not needed (__add_measure_all_qubits deleted) and even led to a crash crashed when no qubits were measured
  • With fsp, the simulator will return all qubits as measured, but when there were (removed) measurements in the deterministic algorithm we want to get these measured qubits only in the results (_get_measured_qubit_iterator).

@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d3df66e on fix/SDS-617/measurements_projectq into f4987cd on dev.

@tomrijnbeek tomrijnbeek self-requested a review June 27, 2022 10:03
@QFer QFer requested a review from tomrijnbeek June 28, 2022 08:51
@QFer QFer merged commit 61b0821 into dev Jun 28, 2022
@QFer QFer deleted the fix/SDS-617/measurements_projectq branch June 28, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomrijnbeek tomrijnbeek tomrijnbeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QFer @coveralls @tomrijnbeek