BUG - Fix schema error (#61)

* Fix schema error in themes

* add review changes

* [pre-commit.ci] Apply automatic pre-commit fixes

* 👷 Add ignore links

---------

Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

.github/workflows/check-links.yml

@@ -13,3 +13,5 @@ jobs:
       - uses: actions/checkout@v3
       - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
       - uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
+        with:
+          ignore_links: "https://via.placeholder.com/"

README.md

@@ -52,7 +52,7 @@ This font can only be changed for the `Markdown viewer` and the `Terminal`. You
 
 ## Requirements 📦
 
-- [JupyterLab](https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html)  >= 3.0, <4.0
+- [JupyterLab](https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html) >= 3.0, <4.0
 
 ## Installing the extension 🏗
 

lerna.json

@@ -1,8 +1,6 @@
 {
-  "workspaces": ["packages/*"],
   "useNx": false,
   "version": "0.0.0",
-  "packages": ["packages/*"],
   "$schema": "node_modules/lerna/schemas/lerna-schema.json",
   "useWorkspaces": true
 }

package.json

@@ -22,8 +22,7 @@
   },
   "files": [
     "lib/**/*.{d.ts,eot,gif,html,jpg,js,js.map,json,png,svg,woff2,ttf}",
-    "style/**/*.{css,js,eot,gif,html,jpg,json,png,svg,woff2,ttf}",
-    "schema/*.json"
+    "style/**/*.{css,js,eot,gif,html,jpg,json,png,svg,woff2,ttf}"
   ],
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

packages/githublight/src/index.ts

@@ -8,8 +8,6 @@ import {
 
 import { IThemeManager } from "@jupyterlab/apputils";
 
-import { ISettingRegistry } from "@jupyterlab/settingregistry";
-
 /**
  * Initialization data for the jupyterlab-accessible-themes extension.
  */
@@ -19,12 +17,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
   id: "jupyterlab-accessible-themes:githublight",
   autoStart: true,
   requires: [IThemeManager],
-  optional: [ISettingRegistry],
-  activate: (
-    app: JupyterFrontEnd,
-    manager: IThemeManager,
-    settingRegistry: ISettingRegistry | null,
-  ) => {
+  activate: (app: JupyterFrontEnd, manager: IThemeManager) => {
     console.log(
       "JupyterLab extension jupyterlab-accessible-themes is activated!",
     );
@@ -39,23 +32,6 @@ const plugin: JupyterFrontEndPlugin<void> = {
       load: () => manager.loadCSS(style),
       unload: () => Promise.resolve(undefined),
     });
-
-    if (settingRegistry) {
-      settingRegistry
-        .load(plugin.id)
-        .then((settings) => {
-          console.log(
-            "jupyterlab-accessible-themes settings loaded:",
-            settings.composite,
-          );
-        })
-        .catch((reason) => {
-          console.error(
-            "Failed to load settings for jupyterlab-accessible-themes.",
-            reason,
-          );
-        });
-    }
   },
 };
 

packages/pitayasmoothie/src/index.ts

@@ -8,8 +8,6 @@ import {
 
 import { IThemeManager } from "@jupyterlab/apputils";
 
-import { ISettingRegistry } from "@jupyterlab/settingregistry";
-
 /**
  * Initialization data for the jupyterlab-accessible-themes extension.
  */
@@ -19,12 +17,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
   id: "jupyterlab-accessible-themes:pitayasmoothie",
   autoStart: true,
   requires: [IThemeManager],
-  optional: [ISettingRegistry],
-  activate: (
-    app: JupyterFrontEnd,
-    manager: IThemeManager,
-    settingRegistry: ISettingRegistry | null,
-  ) => {
+  activate: (app: JupyterFrontEnd, manager: IThemeManager) => {
     console.log(
       "JupyterLab extension jupyterlab-accessible-themes is activated!",
     );
@@ -39,23 +32,6 @@ const plugin: JupyterFrontEndPlugin<void> = {
       load: () => manager.loadCSS(style),
       unload: () => Promise.resolve(undefined),
     });
-
-    if (settingRegistry) {
-      settingRegistry
-        .load(plugin.id)
-        .then((settings) => {
-          console.log(
-            "jupyterlab-accessible-themes settings loaded:",
-            settings.composite,
-          );
-        })
-        .catch((reason) => {
-          console.error(
-            "Failed to load settings for jupyterlab-accessible-themes.",
-            reason,
-          );
-        });
-    }
   },
 };