-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme with latest instructions and requirements #60
Conversation
👈 Launch a binder notebook on branch Quansight-Labs/jupyterlab-accessible-themes/update-readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only adds the instructions to the readme, but I just realised that the pyproject.toml
is incomplete and needs updating:
- There is no
requires-python
@@ -54,24 +54,29 @@ This font can only be changed for the `Markdown viewer` and the `Terminal`. You | |||
|
|||
## 📦 Requirements | |||
|
|||
- [JupyterLab](https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html) >= 3.0 | |||
- [JupyterLab](https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html) < 4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be >= 3.0, <4.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good catch
Follow-up PR fixing #60 (comment)
Follow-up PR fixing #60 (comment)
Part of #56
This PR,