Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with latest instructions and requirements #60

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Jul 3, 2023

Part of #56

This PR,

  • Updates readme with instructions for installation to end users
  • Fix python version in readme
  • Update maximum JupyterLab version

@steff456 steff456 requested a review from trallard July 3, 2023 21:10
@steff456 steff456 self-assigned this Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Binder 👈 Launch a binder notebook on branch Quansight-Labs/jupyterlab-accessible-themes/update-readme
Comment updated on 2023-07-10T23:03:33.642Z

Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only adds the instructions to the readme, but I just realised that the pyproject.toml is incomplete and needs updating:

  • There is no requires-python

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@trallard trallard merged commit a49d25e into main Jul 11, 2023
@trallard trallard deleted the update-readme branch July 11, 2023 12:36
@@ -54,24 +54,29 @@ This font can only be changed for the `Markdown viewer` and the `Terminal`. You

## 📦 Requirements

- [JupyterLab](https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html) >= 3.0
- [JupyterLab](https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html) < 4.0
Copy link
Contributor

@gabalafou gabalafou Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be >= 3.0, <4.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good catch

steff456 added a commit that referenced this pull request Jul 12, 2023
trallard pushed a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants