This repository has been archived by the owner on Feb 18, 2023. It is now read-only.
Fix too frequent queries from frontend and too long timeout on backend #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were three issues: - the `notebookTracker.currentChanged` signal was being connected on each re-render of React widget and re-renders were triggered by update to state that was defined in the callback leading to O(n^2) accumulation of callbacks. - the `kernelChanged` signal was being connected on each change of the notebook leading to O(n) accumulation of callbacks. - the sidebar panel could have been created multiple times if invoked from command palette - O(1) accumulation of callbacks.
davidbrochart
added a commit
to davidbrochart/jupyter-resource-usage
that referenced
this pull request
Dec 14, 2022
davidbrochart
added a commit
to jupyter-server/jupyter-resource-usage
that referenced
this pull request
Dec 15, 2022
* initial commit * add Makefile * refactor react state * add a timer with react hook to ensure the panel is refreshed - fixes Quansight/jupyterlab-kernel-usage#6 * panel content for #4 and #7 * new icon fixes #3 * ensure minimal ipykernel version - fixes #8 * format cpu to 1 decimal - fixes #2 * better format the memory numbers - fixes #1 * bump version to 0.2.0 * better format for the memory * bump versoin to 0.3.0 * update preview image * lint * tune the panel layout * show a message is kernel usage is not available * Add PID * readme: add ipykernel requirement - closes #8 * release: 0.4.0 * remove old kernel poll * don't throw timeout exception * remove logging * Pool only the active kernel and if the sidebar is visible * lint * polish the ui and add cpu_count * release: 0.5.0 * Fix issues related to fronted querying too often. There were three issues: - the `notebookTracker.currentChanged` signal was being connected on each re-render of React widget and re-renders were triggered by update to state that was defined in the callback leading to O(n^2) accumulation of callbacks. - the `kernelChanged` signal was being connected on each change of the notebook leading to O(n) accumulation of callbacks. - the sidebar panel could have been created multiple times if invoked from command palette - O(1) accumulation of callbacks. * Limit the backend timeout to 1+2+3=6 seconds total * Clear kernel ID if disposed * Merge jupyterlab-kernel-usage * Add ipykernel dependency * Update README * Pin ipykernel>=6.11.0 * Remove jupyterlab-kernel-usage * Include changes from Quansight/jupyterlab-kernel-usage#24 * Lint * Remove @jupyterlab/launcher dependency Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Eric Charles <eric@datalayer.io> Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23:
In server logs I see a message "Could not destroy zmq context for". This is a potential memory leak. I did not attempt to investigate further given the suggestion in #22 (the backend is more likely to be refactored when merging into
jupyter-resource-usageand this may go away then).