Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CharlesSchwab API (new Lean Plugin) #1

Open
wants to merge 106 commits into
base: master
Choose a base branch
from
Open

Implement CharlesSchwab API (new Lean Plugin) #1

wants to merge 106 commits into from

Conversation

Romazes
Copy link

@Romazes Romazes commented Oct 24, 2024 •
edited
Loading

Description

Related Issue

Related PRs:

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes
refactor: use CharlesSchwabBrokerage instead of template name
f09ac27
@Romazes
rename: all classes/files/namespaces to CharlesSchwab
aa8384d
@Romazes
remove: ToolBox template
6515fec
@Romazes
refactor: workflow event triggers push and pull_request
5f7fbb4
@Romazes
test:remove: ref on ToolBox project
0842da6
@Romazes
feat: Brokerage API TokenRefreshHandler
3d09f17
@Romazes
test:feat: API TokenRefreshHandler
eb7f909
@Romazes
feat: use Cancellation waiter instead of Task delay in TokenRefreshHa…
e536bce 
…ndler
@Romazes
refactor: use partial class and split by different files logic
b4706f2
@Romazes
remove: extra new row
c8678ae
@Romazes
fix: path in oauth/token request endpoint
4c39676
@Romazes
refactor: handler of Token in CharlesSchwabTokenRefreshHandler
5f868a2 
feat: GetAuthorizationUrl
feat: Required property in CharlesSchwabAccessToken
feat: new model CharlesSchwabErrorResponse
test:feat: GetAuthorizationUrl
@Romazes
refactor: name of token error response
da8c2b8
@Romazes
fix: GetAuthorizationUrl
76a3256
@Romazes
feat: CharlesSchwabAccountMetaData Individual trader
615c554
@Romazes
feat: model for error responses
cd4f153
@Romazes
refactor: conifguration property keys
23e5e2d
@Romazes
feat: CharlesSchwabSecuritiesAccount
56e1536 
remove: CharlesSchwabAccountMetaData
@Romazes
feat: start CharlesSchwabApiClient
ca25aec 
test:feat: GetAccount with Mock
@Romazes
feat: CharlesSchwabApiClient
f83ef3a
@Romazes
feat: GetAccountHoldings
dee6cbb 
feat: starting impl Initialize
@Romazes
feat: request method with tradeBaseUrl
246b999
@Romazes
test:fix: name of public method
458a17c
@Romazes
refactor: get rid Instrument record
8164f22
@Romazes
feat: add description to RequestTraderAsync
89d544a
@Romazes Romazes added enhancement New feature or request good first issue Good for newcomers labels Oct 24, 2024
@Romazes Romazes self-assigned this Oct 24, 2024
@Romazes
feat: MarketOnCloseOrder Request
aba30f7 
refactor: CharlesSchwab Order Request
@Romazes
feat: TrailingStopOrder in Brokerage
1b1b490 
test:feat: validate Placing TrailingStopOrder
@Romazes
refactor: verify Expiry Time of AccessToken in TokenrefreshHandler
424e3b6
@Romazes
feat: endpoint GetUserPreference in ApiClient
df405ba
@Romazes
feat: endpoint GetUserPreference in ApiClient
c1a3622
@Romazes
Merge branch 'develop' of https://github.com/Romazes/Lean.Brokerages.…
84316c9 
…CharlesSchwab into develop
@Romazes
feat: CharlesSchwabWebSocketClientWrapper and models
c0080bb
@Romazes
feat: handle Order Update events through WS
94a30eb
@Romazes
refactor: PlaceOrder Api endpoint
4609866 
refactor: RequestAsync methods()
@Romazes
feat: PlaceOrder
7bf6bd0 
feat: Handle Cancel or Invalid stream order responses
@Romazes
refactor: CancelOrder()
4738892 
feat: create enum for MessageType
@Romazes
remove: not support OrderTypes
328b54a
@Romazes
refactor: return empty holding if account doesn't keep positions
c44d14d 
refactor: ConversionRate and MarketPrice in GetAccountHoldings
feat: Handle Invalid Order Status when PlacedNewOrder
feat: Handle Exception in CancelOrder
feat: Handle Filled,Reject,Cancel OrderEvent
remove: Catch exception in Api PlaceOrder
feat: OrderFillCompleted in MessageType
feat: new AccountActivity entities
test:feat: Split test on Equity and Option
@Romazes
feat: GetInstructionByDirection
aeed747 
remove: support Future Symbol in SymbolMapper
test:refactor: trading test cases
@Romazes
feat: Equity Data Queue Handler
d657e07 
feat: Custom Convert of Data Content
test:feat: DataQueueHandler
@Romazes
feat: Equity,Index,Option,IndexOption Data Queue Handler
28bb7cc
@Romazes
refactor: restriction on minute history resolution
669066f 
test:feat: history requests
@Romazes
feat: implement DataQueueUniverseProvider
49d424e 
feat: new ErrorResponse in Api
test:refactor: new initializer of Brokerage in TestSetup
@Romazes
fix: name class in exception message
b814dab
@Romazes
feat: CharlesSchwabBrokerageFactory
5358b43 
feat: SetJob
refactor: add missed xml description
@Romazes
fix: getting config from LiveNodePacket in Factory
825c74c 
test:feat: BrokerageFactory
@Romazes
test:feat: new tests of HistoryProvider
cce4787
@Romazes
feat: UpdateOrder
2c4106d 
test:feat: Update Order Equity\Option
feat: new MessageTypes
fix: IsOrderOpen extension
fix: handle order exception in ApiClient
@Romazes
feat: CanSubmitOrder
fba2b82 
refactor: skip duplicate order event
refactor: make error exception more developer friendly
feat: support Place IndexOption
test:feat: IndexOption (Index doesn't support)
@Romazes
fix: ConvertDateTimeToUnix in API GetHistory
080c989
@Romazes
feat: ReSubscription process when the internet is disconnected
30708e5
@Romazes
feat: ValidateSubscription
ca36d3b
@Romazes
fix: call ValidationSubscription in Intializer
2994d9e
This was referenced Nov 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martin-Molinero Martin-Molinero Awaiting requested review from Martin-Molinero

Assignees

@Romazes Romazes

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Romazes