Refactor schemas and runners into classes #1833
Labels
Comments
Andrew-S-Rosen
added
the
housekeeping
This was referenced Apr 21, 2024
Merged
Andrew-S-Rosen
added a commit
that referenced
this issue
Jun 11, 2024
## Summary of Changes Partially addresses #1833. This should not affect anything user-facing, although it does close #2230. ### Checklist - [X] I have read the ["Guidelines" section](https://quantum-accelerators.github.io/quacc/dev/contributing.html#guidelines) of the contributing guide. Don't lie! 😉 - [X] My PR is on a custom branch and is _not_ named `main`. - [X] I have added relevant, comprehensive [unit tests](https://quantum-accelerators.github.io/quacc/dev/contributing.html#unit-tests). ### Notes - Your PR will likely not be merged without proper and thorough tests. - If you are an external contributor, you will see a comment from [@buildbot-princeton](https://github.com/buildbot-princeton). This is solely for the maintainers. - When your code is ready for review, ping one of the [active maintainers](https://quantum-accelerators.github.io/quacc/about/contributors.html#active-maintainers). --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to report?
There is a fair bit too much copy/paste around for my liking. The best place to start tackling this is to refactor some of the
quacc.schemasto inherit from common base classes and use an object-oriented approach. There is also the possibility of doing this for other modules (e.g.quacc.runnersis an ideal place).The text was updated successfully, but these errors were encountered: