Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double _ methods #2023

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Remove double _ methods #2023

merged 1 commit into from
Apr 21, 2024

Conversation

Andrew-S-Rosen
Copy link
Member

Summary of Changes

No need for us to hide methods that are already hidden.

Checklist

  • I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • My PR is on a custom branch and is not named main.
  • I have added relevant, comprehensive unit tests.

Notes

  • Your PR will likely not be merged without proper and thorough tests.
  • If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
  • When your code is ready for review, ping one of the active maintainers.

@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) April 21, 2024 04:19
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.13%. Comparing base (352d3cc) to head (1ff7ee5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2023   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          81       81           
  Lines        3338     3338           
=======================================
  Hits         3309     3309           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-S-Rosen Andrew-S-Rosen merged commit 71bd6f5 into main Apr 21, 2024
20 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the double branch April 21, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant