Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Write out results to JSON instead of pickle #2025

Merged
merged 21 commits into from
May 16, 2024
Merged

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Apr 21, 2024

Summary of Changes

Write out the results to a JSON file instead of a pickle file to prevent potential security issues. It can be read in as:

from monty.serialization import loadfn

results = loadfn("quacc_results.json.gz")

It can also be viewed in any text editor.

Checklist

  • I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • My PR is on a custom branch and is not named main.
  • I have added relevant, comprehensive unit tests.

Notes

  • Your PR will likely not be merged without proper and thorough tests.
  • If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
  • When your code is ready for review, ping one of the active maintainers.

@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft April 21, 2024 05:24
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (56c1caf) to head (88cd57a).

❗ Current head 88cd57a differs from pull request most recent head 6dc814c. Consider uploading reports for the commit 6dc814c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2025   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          81       81           
  Lines        3339     3339           
=======================================
  Hits         3307     3307           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-S-Rosen Andrew-S-Rosen added the enhancement New feature or request label Apr 22, 2024
@Andrew-S-Rosen Andrew-S-Rosen added the waiting-for-upstream Issue or PR is waiting for an upstream code change. label May 13, 2024
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as ready for review May 16, 2024 01:52
@Andrew-S-Rosen Andrew-S-Rosen removed the waiting-for-upstream Issue or PR is waiting for an upstream code change. label May 16, 2024
@Andrew-S-Rosen Andrew-S-Rosen changed the title Write out results to JSON instead of pickle [BREAKING] Write out results to JSON instead of pickle May 16, 2024
@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) May 16, 2024 02:44
@Andrew-S-Rosen Andrew-S-Rosen disabled auto-merge May 16, 2024 02:44
@Andrew-S-Rosen Andrew-S-Rosen merged commit 1e922c9 into main May 16, 2024
16 of 17 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the json2 branch May 16, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

1 participant