-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Write out results to JSON instead of pickle #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2025 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 81 81
Lines 3339 3339
=======================================
Hits 3307 3307
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Andrew-S-Rosen
added
the
waiting-for-upstream
Issue or PR is waiting for an upstream code change.
label
May 13, 2024
Andrew-S-Rosen
removed
the
waiting-for-upstream
Issue or PR is waiting for an upstream code change.
label
May 16, 2024
Andrew-S-Rosen
changed the title
Write out results to JSON instead of pickle
[BREAKING] Write out results to JSON instead of pickle
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Write out the results to a JSON file instead of a pickle file to prevent potential security issues. It can be read in as:
It can also be viewed in any text editor.
Checklist
main
.Notes