Warn users about a future breaking change to relax_cell
in VASP recipes
#2299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As noted in #1887, the VASP recipes are the only ones throughout quacc with
relax_cell = True
by default (namely:relax_job
andase_relax_job
). This can lead to unexpected behavior for users that run multiple codes in quacc. To streamline things, eventually we will makerelax_cell = False
by default. This would be a notable breaking change, so we will not do so for some time. The warning may be perceived as annoying, but it is perhaps worthwhile.Requirements
main
.Notes