Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor settings changes, mainly to fit Material Design #710

Closed
wants to merge 1 commit into from

Conversation

Cguy7777
Copy link
Contributor

The main purpose of this PR is to change the preferences strings to match Material Design's recommendations, by changing capitalization and re-wording several strings. It might be a good idea to add a link or note about this to the wiki page about adding preferences to help keep the strings for new preferences in line.

This PR also has a few other minor changes:

  • Make the Use Custom Tabs preference dependent on Use internal browser, since it has no effect if that's disabled
  • Move Tablet mode (two pane) to the top of the appearance preferences and remove its PreferenceCategory (it was the only one in there)
  • Add a summary for Use Tor to remind users that links will not be sent over Tor if they are not using the built-in WebView browser
  • Add a summary for Comment header to clarify its purpose

@QuantumBadger
Copy link
Owner

Merged in, thanks!

edcfd73

@Cguy7777 Cguy7777 deleted the settings_changes branch June 17, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants