-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potts edits #29
Potts edits #29
Conversation
This reverts commit ba4a409.
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a great first PR!
I have just a couple remarks before we can get this merged:
Could you run the formatter, such that the formatter check is happy? This is done file-by-file in VSCode by rightclicking the file and selecting the format option, or for an entire directory (and its subdirectories) by:
using JuliaFormatter
format("path_to_directory")
I think we could consider renaming the operators a bit. U_matrix
and V_matrix
don't give too much information, and could be anything, so I would suggest:
potts_X
and potts_Z
, as generalizations to pauli_X
etc.
Note that our convention is to have XX + Z
as the Ising model, as Z
is diagonal in the symmetry basis, so this would mean writing the model as \sum_i potts_XX^i + potts_Z^i
or something to keep the consistency. (ie, potts_X should be the non-diagonal one in the symmetric basis!). If this is very strange, we can also consider changing the convention in the ising model to have X
be diagonal, but that is somehow also strange to me.
I think it would be very nice if the operators themselves could be tested as well. I am mostly considering Z^q = 1
, and the commutation relations, which should be relatively straightforward to test? See also this file
Finally, it is nice for discoverability to have them added to the docs as well. Probably somewhere here would be perfect.
…with Z_Q symmetry
…ry via block structure
…ry since ill-defined
generalise the Potts operators for arbitrary Q, as well as tests to check these for Q=4 and Q=5.