Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qubes-dom0-update ignores --check-only option #7417

Closed
jevank opened this issue Apr 4, 2022 · 2 comments
Closed

qubes-dom0-update ignores --check-only option #7417

jevank opened this issue Apr 4, 2022 · 2 comments
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: updates diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. r4.1-dom0-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.1 updates

Comments

@jevank
Copy link

jevank commented Apr 4, 2022 •
edited
Loading

How to file a helpful issue

Qubes OS release

R4.1

Brief summary

qubes-dom0-update tool ignores the --check-only option and this breaks daily update check task.

Steps to reproduce

sudo qubes-dom0-update --check-only

Expected behavior

sudo qubes-dom0-update --check-only makes check-only request

Actual behavior

sudo qubes-dom0-update --check-only downloads and tries to install updates
@jevank jevank added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Apr 4, 2022
@andrewdavidwong andrewdavidwong changed the title Dom0 update check is broken qubes-dom0-update ignores --check-only option Apr 6, 2022
@andrewdavidwong andrewdavidwong added P: major Priority: major. Between "default" and "critical" in severity. needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. C: updates and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Apr 6, 2022
@andrewdavidwong andrewdavidwong added this to the Release 4.1 updates milestone Apr 6, 2022
@lubellier lubellier mentioned this issue Apr 12, 2022
Closed
marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue Apr 13, 2022
@marmarek
qubes-dom0-update: Pass --check-only option to the updatevm too
87c4591 
The updatevm script does need this option too, for two reasons:
 - to skip downloading updates if only check was requested
 - to report updates availability via exit code

The second point is critical for setting 'updates-available' flag.

Fixs QubesOS/qubes-issues#7417
@marmarek marmarek mentioned this issue Apr 13, 2022
Merged
@marmarek marmarek added diagnosed Technical diagnosis has been performed (see issue comments). and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Apr 13, 2022
@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin-linux (including package qubes-core-dom0-linux-4.1.20-1.fc32) has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

This was referenced Apr 13, 2022
Closed
Closed
marmarek added a commit to QubesOS/qubes-core-admin-linux that referenced this issue Apr 15, 2022
@marmarek
qubes-dom0-update: Pass --check-only option to the updatevm too
fd67b8c 
The updatevm script does need this option too, for two reasons:
 - to skip downloading updates if only check was requested
 - to report updates availability via exit code

The second point is critical for setting 'updates-available' flag.

Fixs QubesOS/qubes-issues#7417

(cherry picked from commit 87c4591)
@qubesos-bot qubesos-bot mentioned this issue Apr 15, 2022
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin-linux (including package qubes-core-dom0-linux-4.1.21-1.fc32) has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@eloquence eloquence mentioned this issue Jun 7, 2022
Closed
@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: updates diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. r4.1-dom0-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.1 updates
Development

No branches or pull requests
4 participants
@marmarek @andrewdavidwong @qubesos-bot @jevank