update

QubitPi · Apr 20, 2023 · 26071ec · 26071ec
1 parent 560f687
commit 26071ec
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 16 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -10,3 +10,24 @@ BEFORE YOU SUBMIT make sure you've done the following:
 More details on contributing can be found in CONTRIBUTING.md in the root of this repository. Thank you for your time and interest in the Neo4j Browser! 
 -->
 
+Changelog
+---------
+
+### Added
+
+### Changed
+
+### Deprecated
+
+### Removed
+
+### Fixed
+
+### Security
+
+Checklist
+---------
+
+* [ ] Test
+* [ ] Self-review
+* [ ] Documentation
diff --git a/.github/workflows/release-doc.yml b/.github/workflows/release-doc.yml
@@ -2,8 +2,9 @@
 name: Release
 
 "on":
-  pull_request:
-    types: [opened, synchronize, reopened]
+  push:
+    branches:
+      - master
 
 jobs:
   release-documentation:

diff --git a/src/neo4j-arc/graph-visualization/GraphVisualizer/Graph/visualization/renderers/menu.ts b/src/neo4j-arc/graph-visualization/GraphVisualizer/Graph/visualization/renderers/menu.ts
@@ -42,6 +42,8 @@ const drawArc = function (radius: number, itemNumber: number, width = 30) {
     .padAngle(0.03)
 }
 
+const getSelectedNode = (node: NodeModel) => (node.selected ? [node] : [])
+
 const attachContextEvent = (
   eventType: string,
   elements: [
@@ -77,18 +79,10 @@ const attachContextEvent = (
 }
 
 /**
- * This function gets triggered when {@link !getSelectedNode} evaluates to true, i.e. only "mouse-clicked" node will
- * have the menu rendering
- * executed
- * @param selection
- * @param viz
- * @param eventType
- * @param itemIndex
- * @param className
- * @param position
- * @param svgIconKey
- * @param tooltip
- * @returns
+ * When a node is clicked, this function is triggered.
+ *
+ * There is a D3 data join in this function that only binds visual element when {@link !getSelectedNode} evaluates to
+ * true, i.e. only "mouse-clicked" node will have the menu rendering executed
  */
 const createMenuItem = function (
   selection: Selection<SVGGElement, NodeModel, BaseType, unknown>,
@@ -162,8 +156,6 @@ const createMenuItem = function (
   return icon
 }
 
-const getSelectedNode = (node: NodeModel) => (node.selected ? [node] : [])
-
 const donutRemoveNode = new Renderer<NodeModel>({
   name: 'donutRemoveNode',
   onGraphChange(selection, viz) {